turboFei commented on code in PR #4019:
URL: https://github.com/apache/incubator-kyuubi/pull/4019#discussion_r1054236856
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/session/SparkSQLSessionManager.scala:
##########
@@ -177,3 +181,18 @@ class SparkSQLSessionManager private (name: String, spark:
SparkSession)
override protected def isServer: Boolean = false
}
+
+object SparkSQLSessionManager {
+ private val sessionManager = new AtomicReference[SparkSQLSessionManager]
+
+ private def setSessionManager(manager: SparkSQLSessionManager): Unit = {
+ sessionManager.set(manager)
+ }
+
+ def getSparkSession(uuid: String): SparkSession = {
+ sessionManager.get()
Review Comment:
with that, SparkSQLSessionManager::setSessionManager is not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
