bowenliang123 commented on PR #3699: URL: https://github.com/apache/kyuubi/pull/3699#issuecomment-1371683386
Noticed the magic values for plan name matching are coming back in the current implementation. Consider adapting the implementation to the new Serde design pattern in Authz, especially in PR https://github.com/apache/kyuubi/pull/3904 , https://github.com/apache/kyuubi/pull/4044. Use spec and extractor or post-action to do the same purpose. As for the feature in this PR, I am good with it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
