Yikf commented on PR #4113: URL: https://github.com/apache/kyuubi/pull/4113#issuecomment-1375340739
> After this change, we can not determine whether the log is failed or just not implemented Good point, Have a question is which of the following designs is more reasonable: 1. Fetch empty log if the operation don't implements getOperationLog 2. Have the contract, client will only call fetching log for those operations which implement getOperationLog If 1, we can handle whether the log is failed or just not implemented; if 2, we can handle this case according to this contract at client/jdbc engine side; > shall be able to benefit from the current implementation too. What are the benefits? (sorry for I didn't know the previous design ) : ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
