bowenliang123 commented on code in PR #4162:
URL: https://github.com/apache/kyuubi/pull/4162#discussion_r1080757275
##########
bin/kyuubi-logo:
##########
@@ -18,15 +18,15 @@
# Bugzilla 37848: When no TTY is available, don't output to console
have_tty=0
-# shellcheck disable=SC2006
-if [[ "`tty`" != "not a tty" ]]; then
+
Review Comment:
ditto
##########
bin/kyuubi-logo:
##########
@@ -18,15 +18,15 @@
# Bugzilla 37848: When no TTY is available, don't output to console
have_tty=0
-# shellcheck disable=SC2006
-if [[ "`tty`" != "not a tty" ]]; then
+
+if [[ "$(tty)" != "not a tty" ]]; then
have_tty=1
fi
# Bugzilla 37848: When no TTY is available, don't output to console
have_tty=0
-# shellcheck disable=SC2006
-if [[ "`tty`" != "not a tty" ]]; then
+
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
