turboFei commented on issue #4457: URL: https://github.com/apache/kyuubi/issues/4457#issuecomment-1459103736
> @turboFei @yaooqinn Do you think it's reasonable to add something like `protocol.getTransport().close()` after the `shutdownAsyncRequestExecutor()` in `startEngineAliveProbe()`. > > https://github.com/apache/kyuubi/blob/3d65f2711faa5dc9173130557e2d33adab04b5c7/kyuubi-server/src/main/scala/org/apache/kyuubi/client/KyuubiSyncThriftClient.scala#L110-L112 > > After adding this thrift client connection can be closed. It should be okay because the engine is dead anyway. What do you think? Thanks @risyomei It sounds good if the `kyuubi.session.engine.alive.timeout` is reasonable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
