bowenliang123 commented on code in PR #4777:
URL: https://github.com/apache/kyuubi/pull/4777#discussion_r1178740603
##########
kyuubi-events/src/main/scala/org/apache/kyuubi/events/handler/JsonLoggingEventHandler.scala:
##########
@@ -108,6 +119,7 @@ class JsonLoggingEventHandler(
}
object JsonLoggingEventHandler {
- val JSON_LOG_DIR_PERM: FsPermission = new
FsPermission(Integer.parseInt("770", 8).toShort)
- val JSON_LOG_FILE_PERM: FsPermission = new
FsPermission(Integer.parseInt("660", 8).toShort)
+ private val JSON_LOG_DIR_PERM: FsPermission = new
FsPermission(Integer.parseInt("770", 8).toShort)
+ private val JSON_LOG_FILE_PERM: FsPermission =
Review Comment:
They could be private only and the changes are optional. This pr is closing
the inside intermediateness of the json event handlers, so I think good to
retract these two variables in private accessibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
