pan3793 commented on code in PR #5066:
URL: https://github.com/apache/kyuubi/pull/5066#discussion_r1269106981
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/ProcBuilder.scala:
##########
@@ -257,7 +261,13 @@ trait ProcBuilder {
logCaptureThread = null
}
if (destroyProcess && process != null) {
- process.destroyForcibly()
+ process.destroy()
+ if (!process.waitFor(engineStartupDestroyTimeout,
TimeUnit.MILLISECONDS)) {
+ warn("Engine startup process does not exit after " +
+ s"$engineStartupDestroyTimeout" ms, try to forcibly kill. " +
Review Comment:
```suggestion
s"$engineStartupDestroyTimeout ms, try to forcibly kill. " +
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
