pan3793 commented on code in PR #5120:
URL: https://github.com/apache/kyuubi/pull/5120#discussion_r1283530666
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -2657,6 +2657,13 @@ object KyuubiConf {
.stringConf
.createOptional
+ val ENGINE_JDBC_USE_SESSION_USER_PASSWORD: ConfigEntry[Boolean] =
+ buildConf("kyuubi.engine.jdbc.connection.use.session.user.password")
Review Comment:
I recommend to
1. rename it to `kyuubi.engine.jdbc.propagateCredential`
2. make it only takes effect on CONNECTION/USER share level
3. mark as internal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
