pan3793 commented on code in PR #5160:
URL: https://github.com/apache/kyuubi/pull/5160#discussion_r1294195665
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/service/TFrontendService.scala:
##########
@@ -520,23 +520,20 @@ abstract class TFrontendService(name: String)
override def FetchResults(req: TFetchResultsReq): TFetchResultsResp = {
debug(req.toString)
- val resp = new TFetchResultsResp
try {
val operationHandle = OperationHandle(req.getOperationHandle)
val orientation =
FetchOrientation.getFetchOrientation(req.getOrientation)
// 1 means fetching log
val fetchLog = req.getFetchType == 1
val maxRows = req.getMaxRows.toInt
- val rowSet = be.fetchResults(operationHandle, orientation, maxRows,
fetchLog)
- resp.setResults(rowSet)
- resp.setHasMoreRows(false)
Review Comment:
Seems we need to call this method explicitly.
```
public void setHasMoreRows(boolean hasMoreRows) {
this.hasMoreRows = hasMoreRows;
setHasMoreRowsIsSet(true);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
