bowenliang123 commented on code in PR #5143:
URL: https://github.com/apache/kyuubi/pull/5143#discussion_r1296024845
##########
extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/FunctionPrivilegesBuilderSuite.scala:
##########
@@ -58,8 +60,12 @@ abstract class FunctionPrivilegesBuilderSuite extends
AnyFunSuite
checkColumns(sql(query).queryExecution.optimizedPlan, cols)
}
+ protected val HIVE_MASK_HASH_CLASS =
"org.apache.hadoop.hive.ql.udf.generic.GenericUDFMaskHash"
+ protected val HIVE_FUNCTION_NAME_BASE = "hive_func"
+ protected val OBJECT_NAME_SEPARATOR = "_"
+
protected val reusedDb: String = getClass.getSimpleName
- protected val reusedDb2: String = getClass.getSimpleName + "2"
+ protected val reusedDb2: String = getClass.getSimpleName +
s"${OBJECT_NAME_SEPARATOR}2"
Review Comment:
```suggestion
protected val reusedDb2: String =
s"${getClass.getSimpleName}${OBJECT_NAME_SEPARATOR}2"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
