bowenliang123 commented on code in PR #5182:
URL: https://github.com/apache/kyuubi/pull/5182#discussion_r1299893153
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionManager.scala:
##########
@@ -361,13 +368,29 @@ class KyuubiSessionManager private (name: String) extends
SessionManager(name) {
batchLimiter.foreach(SessionLimiter.resetUnlimitedUsers(_, unlimitedUsers))
}
+ private[kyuubi] def getLimitedUsers: Set[String] = {
+
limiter.orElse(batchLimiter).map(SessionLimiter.getLimitedUsers).getOrElse(Set.empty)
+ }
+
+ private[kyuubi] def refreshLimitedUsers(conf: KyuubiConf): Unit = {
+ val limitedUsers =
conf.get(SERVER_LIMIT_CONNECTIONS_USER_LIMITED_LIST).toSet
Review Comment:
The user list should be filtered ensuring non-empty elements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
