cxzl25 commented on code in PR #5161:
URL: https://github.com/apache/kyuubi/pull/5161#discussion_r1301187412
##########
externals/kyuubi-jdbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/operation/ExecuteStatement.scala:
##########
@@ -67,9 +70,23 @@ class ExecuteStatement(
iter =
if (incrementalCollect) {
info("Execute in incremental collect mode")
- new IterableFetchIterator(resultSetWrapper.toIterable)
+ new IterableFetchIterator[Row](new Iterable[Row] {
+ private val fetched = new AtomicBoolean(false)
+ override def iterator: Iterator[Row] = {
+ if (fetched.getAndSet(true)) {
+ jdbcStatement.synchronized {
Review Comment:
Would re-execution be a possible problem? For example, insert is executed
twice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
