pan3793 commented on PR #5182: URL: https://github.com/apache/kyuubi/pull/5182#issuecomment-1695572612
@zhuyaogai I'm not sure if we have gaps in the logic design. The code implementation and the test cases do not cover the combinations of `limited.users` and `unlimited.users`. 1. Neither `limited.users` nor `unlimited.users` are configured 2. Only `limited.users` is configured 3. Only `unlimited.users` is configured 4. Both `limited.users` and `unlimited.users` are configured seems the current code only considers case 4? > that's why we discuss the priority of `limited.user.list` and `unlimited.user.list`, I think it's fine that `limited.user.list` takes high priority. (it means when `limited.user.list` is configured, ignore `unlimited.user.list`) And I suppose we reached a consensus on what the behavior should be like for case 4, but the code looks do not match. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
