pan3793 commented on code in PR #5196:
URL: https://github.com/apache/kyuubi/pull/5196#discussion_r1319468283
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiServer.scala:
##########
@@ -34,12 +34,14 @@ import org.apache.kyuubi.metrics.{MetricsConf,
MetricsSystem}
import org.apache.kyuubi.server.metadata.jdbc.JDBCMetadataStoreConf
import org.apache.kyuubi.service.{AbstractBackendService,
AbstractFrontendService, Serverable, ServiceState}
import org.apache.kyuubi.session.KyuubiSessionManager
-import org.apache.kyuubi.util.{KyuubiHadoopUtils, SignalRegister}
+import org.apache.kyuubi.util.{KyuubiHadoopUtils, SemanticVersion,
SignalRegister}
+import org.apache.kyuubi.util.ScalaVersionUtils._
import org.apache.kyuubi.zookeeper.EmbeddedZookeeper
object KyuubiServer extends Logging {
private[kyuubi] var kyuubiServer: KyuubiServer = _
@volatile private[kyuubi] var hadoopConf: Configuration = _
+ lazy val serverRuntimeScalaVersion: SemanticVersion =
scalaRuntimeSemanticVersion
Review Comment:
seems we don't need to introduce this variable, simply call
`SCALA_COMPILE_VERSION` is sufficient?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
