pan3793 commented on code in PR #5310:
URL: https://github.com/apache/kyuubi/pull/5310#discussion_r1329997489
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiRestFrontendService.scala:
##########
@@ -183,10 +183,16 @@ class KyuubiRestFrontendService(override val serverable:
Serverable)
if (!isStarted.get) {
try {
server.start()
- recoverBatchSessions()
isStarted.set(true)
startBatchChecker()
startInternal()
+ // if the server is not started, we should wait for it to start
+ // otherwise, we may get wrong server port with default -1
Review Comment:
```suggestion
// block until the HTTP server is started, otherwise, we may get
// the wrong HTTP server port -1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]