pan3793 commented on PR #5320: URL: https://github.com/apache/kyuubi/pull/5320#issuecomment-1728983796
Actually, this feature is more complicated than simple non-close. the original purpose was to support session recovery on some network issues that occur, we should consider the following things: as both Kyuubi server and engine hold the session instances, if we decide to keep the session alive on the server side - how to ensure the re-create connection reaches the same Kyuubi server? - in which cases, we should close the session immediately, and in which cases not? unconditional retain session may lead the Kyuubi engine to occupy unreasonable resources And how to handle the metrics? should we classify the unattached session into a dedicated group? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
