pan3793 commented on code in PR #5568:
URL: https://github.com/apache/kyuubi/pull/5568#discussion_r1378875842
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/http/authentication/AuthenticationHandler.scala:
##########
@@ -103,23 +101,10 @@ trait AuthenticationHandler {
authorization = authorization.stripPrefix(":").trim
}
// Authorization header must have a payload
- if (authorization == null || authorization.isEmpty()) {
+ if (authorization == null || authorization.isEmpty) {
throw new AuthenticationException(
"Authorization header received from the client does not contain any
data.")
}
authorization
}
}
-
-object AuthenticationHandler {
-
- /**
- * HTTP header used by the SPNEGO server endpoint during an authentication
sequence.
- */
- final val WWW_AUTHENTICATE: String = HttpConstants.WWW_AUTHENTICATE_HEADER
-
- /**
- * HTTP header used by the client endpoint during an authentication sequence.
- */
- final val AUTHORIZATION_HEADER = "Authorization"
Review Comment:
moved such definitions to `HttpAuthUtils`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
