zwangsheng opened a new pull request, #5607:
URL: https://github.com/apache/kyuubi/pull/5607

   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: 
https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
     2. If the PR is related to an issue in 
https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, 
e.g., '[KYUUBI #XXXX] Your PR title ...'.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., 
'[WIP][KYUUBI #XXXX] Your PR title ...'.
   -->
   
   ### _Why are the changes needed?_
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about the use case of it.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   1. fix aSider menu header title font-style
   2. improve engine page filter condition with ALL
   
   ```
   case 1:
   hive.server2.proxy.user: 
   all: true
   
   case 2:
   type: SPARK_SQL
   hive.server2.proxy.user: 
   all: true
   
   case 3:
   type: SPARK_SQL
   sharelevel: CONNECTION
   hive.server2.proxy.user: 
   all: true
   
   case 4:
   type: SPARK_SQL
   sharelevel: CONNECTION
   hive.server2.proxy.user: 123123
   all: false
   ```
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including 
negative and positive cases if possible
   
   - [x] Add screenshots for manual tests if appropriate
   
   - [ ] [Run 
test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests)
 locally before make a pull request
   
   Chrome MacOs dark mode:
   <img width="1298" alt="截屏2023-11-02 11 42 00" 
src="https://github.com/apache/kyuubi/assets/52876270/7af2d008-d15f-479f-8ae2-fd4836160aae";>
   
   Chrome MacOs light mode:
   <img width="1300" alt="截屏2023-11-02 11 43 14" 
src="https://github.com/apache/kyuubi/assets/52876270/eedfa436-3869-437c-802f-1cc6679cc7a3";>
   
   
   ### _Was this patch authored or co-authored using generative AI tooling?_
   <!--
   If a generative AI tooling has been used in the process of authoring this 
patch, please include
   phrase 'Generated-by: ' followed by the name of the tool and its version.
   If no, write 'No'.
   Please refer to the [ASF Generative Tooling 
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
   -->
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to