pan3793 commented on code in PR #5518:
URL: https://github.com/apache/kyuubi/pull/5518#discussion_r1379569324
##########
externals/kyuubi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/session/FlinkSessionImpl.scala:
##########
@@ -64,6 +65,24 @@ class FlinkSessionImpl(
override def open(): Unit = {
val executor =
fSession.createExecutor(Configuration.fromMap(fSession.getSessionConfig))
+ sessionManager.getConf.get(ENGINE_INITIALIZE_SQL).foreach { sql =>
Review Comment:
it's consistent with the current Implementation of the Spark engine.
Additional background: @cfmcgrady proposed a different idea, that
`sparkSession.clone` should be called instead of `sparkSession.newSession` so
that the newly created session could inherit the changes applied to the
bootstrap session. The situation is quite different in Flink since there is no
bootstrap session concept, thus I think the current behavior makes sense.
##########
externals/kyuubi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/session/FlinkSessionImpl.scala:
##########
@@ -64,6 +65,24 @@ class FlinkSessionImpl(
override def open(): Unit = {
val executor =
fSession.createExecutor(Configuration.fromMap(fSession.getSessionConfig))
+ sessionManager.getConf.get(ENGINE_INITIALIZE_SQL).foreach { sql =>
Review Comment:
it's consistent with the current implementation of the Spark engine.
Additional background: @cfmcgrady proposed a different idea, that
`sparkSession.clone` should be called instead of `sparkSession.newSession` so
that the newly created session could inherit the changes applied to the
bootstrap session. The situation is quite different in Flink since there is no
bootstrap session concept, thus I think the current behavior makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
