Kwafoor commented on code in PR #5588:
URL: https://github.com/apache/kyuubi/pull/5588#discussion_r1390092834
##########
externals/kyuubi-jdbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/connection/ConnectionProvider.scala:
##########
@@ -57,10 +57,9 @@ abstract class AbstractConnectionProvider extends Logging {
case None =>
// TODO
if (filteredProviders.size != 1) {
- throw new IllegalArgumentException(
- "JDBC connection initiated but more than one connection provider
was found. Use " +
- s"${ENGINE_JDBC_CONNECTION_PROVIDER.key} option to select a
specific provider. " +
- s"Found active providers ${filteredProviders.mkString("[", ", ",
"]")}")
+ warn("JDBC connection initiated but more than one connection
provider was found. Use " +
Review Comment:
> As both Doris and Mysql server are compatible the mysql driver, how about
simply reuse `Mysql8ConnectionProvider` instead of introducing the new subclass
`MySQLConnectionProvider` ?
This method seems good, but it may lead to confusion when users set the
`kyuubi.engine.jdbc.connection.provider` parameter (since Doris and MySQL use
the same provider). In contrast, I think that since the driver used by the
provider is the same, it does not affect the user's usage. Users just need to
be reminded to set the `kyuubi.engine.jdbc.connection.provider` parameter to
specify the provider.
@pan3793 What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
