zwangsheng commented on code in PR #5714:
URL: https://github.com/apache/kyuubi/pull/5714#discussion_r1396615750
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1231,6 +1231,14 @@ object KyuubiConf {
.checkValue(_ > 0, "must be positive number")
.createWithDefault(Duration.ofMinutes(5).toMillis)
+ val KUBERNETES_SPARK_DELETE_DRIVER_POD_ON_TERMINATION_ENABLED:
ConfigEntry[Boolean] =
+ buildConf("kyuubi.kubernetes.spark.deleteDriverPodOnTermination.enabled")
+ .doc("If set to true then Kyuubi server will delete the spark driver pod
after " +
+ s"the application terminates for
${KUBERNETES_TERMINATED_APPLICATION_RETAIN_PERIOD.key}.")
+ .version("1.8.1")
Review Comment:
> users may want to only delete the Pod completed with exit code 0 but skip
those abnormal exited ones, thus they can get more information to debug later.
Agree with this, maybe we can change this boolean config to enum policy
config, such as NONE, ONLY_COMPLETED, ALL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
