pan3793 commented on code in PR #5588:
URL: https://github.com/apache/kyuubi/pull/5588#discussion_r1399999297
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -2780,9 +2780,24 @@ object KyuubiConf {
val ENGINE_JDBC_CONNECTION_PROVIDER: OptionalConfigEntry[String] =
buildConf("kyuubi.engine.jdbc.connection.provider")
- .doc("The connection provider is used for getting a connection from the
server")
+ .doc("A JDBC connection provider plugin for the Kyuubi Server " +
+ "to establish a connection to the JDBC URL." +
+ " The configuration value should be a subclass of " +
+ "`org.apache.kyuubi.engine.jdbc.connection.JdbcConnectionProvider`. " +
+ "Kyuubi provides the following built-in implementations: " +
+ "<li>doris: For establishing Doris connections.</li> " +
+ "<li>mysql: For establishing MySQL connections.</li> " +
+ "<li>phoenix: For establishing Phoenix connections.</li> " +
+ "<li>postgresql: For establishing PostgreSQL connections.</li>")
.version("1.6.0")
.stringConf
+ .transform {
+ case "Doris" | "doris" => "DorisConnectionProvider"
Review Comment:
I thought we should transform the short name and simple class name to full
class name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
