yaooqinn commented on code in PR #5781:
URL: https://github.com/apache/kyuubi/pull/5781#discussion_r1405920920
##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/rule/permanentview/PermanentViewMarker.scala:
##########
@@ -19,20 +19,15 @@ package
org.apache.kyuubi.plugin.spark.authz.rule.permanentview
import org.apache.spark.sql.catalyst.catalog.CatalogTable
import org.apache.spark.sql.catalyst.expressions.Attribute
-import org.apache.spark.sql.catalyst.plans.logical.{LogicalPlan, UnaryNode}
+import org.apache.spark.sql.catalyst.plans.logical.{LeafNode, LogicalPlan}
import org.apache.kyuubi.plugin.spark.authz.util.WithInternalChild
-case class PermanentViewMarker(
- child: LogicalPlan,
- catalogTable: CatalogTable,
- outputColNames: Seq[String],
- isSubqueryExpressionPlaceHolder: Boolean = false) extends UnaryNode
+case class PermanentViewMarker(child: LogicalPlan, catalogTable: CatalogTable)
extends LeafNode
with WithInternalChild {
override def output: Seq[Attribute] = child.output
override def withNewChildInternal(newChild: LogicalPlan): LogicalPlan =
Review Comment:
is this still necessary？
##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/rule/permanentview/PermanentViewMarker.scala:
##########
@@ -19,20 +19,15 @@ package
org.apache.kyuubi.plugin.spark.authz.rule.permanentview
import org.apache.spark.sql.catalyst.catalog.CatalogTable
import org.apache.spark.sql.catalyst.expressions.Attribute
-import org.apache.spark.sql.catalyst.plans.logical.{LogicalPlan, UnaryNode}
+import org.apache.spark.sql.catalyst.plans.logical.{LeafNode, LogicalPlan}
import org.apache.kyuubi.plugin.spark.authz.util.WithInternalChild
-case class PermanentViewMarker(
- child: LogicalPlan,
- catalogTable: CatalogTable,
- outputColNames: Seq[String],
- isSubqueryExpressionPlaceHolder: Boolean = false) extends UnaryNode
+case class PermanentViewMarker(child: LogicalPlan, catalogTable: CatalogTable)
extends LeafNode
with WithInternalChild {
override def output: Seq[Attribute] = child.output
override def withNewChildInternal(newChild: LogicalPlan): LogicalPlan =
Review Comment:
is this still necessary？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
