bowenliang123 commented on code in PR #5767:
URL: https://github.com/apache/kyuubi/pull/5767#discussion_r1412218818
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/spark/SparkBatchProcessBuilder.scala:
##########
@@ -51,13 +52,12 @@ class SparkBatchProcessBuilder(
// tag batch application
KyuubiApplicationManager.tagApplication(batchId, "spark",
clusterManager(), batchKyuubiConf)
- (batchKyuubiConf.getAll ++
- sparkAppNameConf() ++
- engineLogPathConf() ++
- appendPodNameConf(batchConf)).foreach { case (k, v) =>
- buffer += CONF
- buffer += s"${convertConfigKey(k)}=$v"
- }
+ val allConfigs = Seq(
+ batchKyuubiConf.getAll,
+ sparkAppNameConf(),
+ engineLogPathConf(),
+ appendPodNameConf(batchConf)).flatten
+ buffer ++= confKeyValues(allConfigs)
Review Comment:
Have considered the style that you suggest. Maybe I would prefer separating
the configs assembling and the command buffer assembling, easier for
readability and the further modifications in configs assembling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
