pan3793 commented on code in PR #5591:
URL: https://github.com/apache/kyuubi/pull/5591#discussion_r1418544744


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1893,6 +1893,28 @@ object KyuubiConf {
       .intConf
       .createWithDefault(0)
 
+  val OPERATION_RESULT_SAVE_TO_FILE: ConfigEntry[Boolean] =
+    buildConf("kyuubi.operation.result.save.to.file")
+      .doc("The switch for Spark query result save to hdfs file")
+      .version("1.9.0")
+      .booleanConf
+      .createWithDefault(false)
+
+  val OPERATION_RESULT_SAVE_TO_FILE_PATH: ConfigEntry[String] =
+    buildConf("kyuubi.operation.result.save.to.file.path")
+      .doc("The hdfs path of Spark query result save")

Review Comment:
   can we have some description of:
   
   how does it organize the data under this dir?
   who is responsible for cleaning up the data?
   who is the producer/consumer of the data, and what permission should the 
folder be guaranteed?
   
   I guess the user may ask the above questions when they explore this feature, 
would be nice if you can document those information



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to