pan3793 commented on code in PR #5851:
URL: https://github.com/apache/kyuubi/pull/5851#discussion_r1427632437
##########
externals/kyuubi-chat-engine/src/main/scala/org/apache/kyuubi/engine/chat/operation/ChatOperation.scala:
##########
@@ -45,8 +46,11 @@ abstract class ChatOperation(session: Session) extends
AbstractOperation(session
iter.fetchAbsolute(0)
}
- val taken = iter.take(rowSetSize)
- val resultRowSet = RowSet.toTRowSet(taken.toSeq, 1, getProtocolVersion)
+ val taken = iter.take(rowSetSize).map(_.toSeq)
+ val resultRowSet = new RowSetGenerator().toTRowSet(
Review Comment:
that makes sense. thanks for explanation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
