turboFei commented on PR #5875:
URL: https://github.com/apache/kyuubi/pull/5875#issuecomment-1862195292
> LGTM for this pr.
>
> But I still have some confusion.
>
> 1. The API for obtaining session and operation details are inconsistent:
`@Path("{sessionHandle}")` and `@Path("{operationHandle}/event")`
> 2. The naming of `dto.KyuubiOperationEvent` and `dto.KyuubiSessionEvent`
is confusing, they represent the details of the current session and operation,
maybe named `KyuubiXXXDto` is more appropriate.
Thanks, let us followup it in another pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
