pan3793 commented on code in PR #5970:
URL: https://github.com/apache/kyuubi/pull/5970#discussion_r1451917200
##########
externals/kyuubi-trino-engine/src/main/scala/org/apache/kyuubi/engine/trino/session/TrinoSessionImpl.scala:
##########
@@ -141,7 +144,7 @@ class TrinoSessionImpl(
require(
serverScheme.equalsIgnoreCase("https"),
"Trino engine using username/password requires HTTPS to be enabled")
- builder.addInterceptor(OkHttpUtil.basicAuth(username, password))
+ builder.addInterceptor(OkHttpUtil.basicAuth(trinoUser, password))
Review Comment:
The ClientSession still uses username(session user), will this cause issues?
##########
externals/kyuubi-trino-engine/src/main/scala/org/apache/kyuubi/engine/trino/session/TrinoSessionImpl.scala:
##########
@@ -141,7 +144,7 @@ class TrinoSessionImpl(
require(
serverScheme.equalsIgnoreCase("https"),
"Trino engine using username/password requires HTTPS to be enabled")
- builder.addInterceptor(OkHttpUtil.basicAuth(username, password))
+ builder.addInterceptor(OkHttpUtil.basicAuth(trinoUser, password))
Review Comment:
The ClientSession still uses `username`(session user), will this cause
issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
