pan3793 commented on code in PR #6003:
URL: https://github.com/apache/kyuubi/pull/6003#discussion_r1461340552
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/EngineRef.scala:
##########
@@ -97,6 +98,8 @@ private[kyuubi] class EngineRef(
case _ => user
}
+ private[kyuubi] val effectiveUser: String = if (doAsEnabled) appUser else
Utils.currentUser
Review Comment:
there are three user variables in this class now,
- `user`: session user
- `appUser`: for engine routing
- `effectiveUser`: for engine launching
those name are not much straightforward, maybe I need to rename them to
- `user` => `sessionUser`
- `appUser` => `routingUser`
- `effectiveUser` => `appUser`
thought?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
