Z1Wu opened a new pull request, #6044:
URL: https://github.com/apache/kyuubi/pull/6044

   ## Why are the changes needed?
   
   Follow-Up of patch: https://github.com/apache/kyuubi/pull/4547
   
   The modification introduced by https://github.com/apache/kyuubi/pull/4547 
will result in all folder whose name is metrics being ignored.
   
   ```
   # for example, a normal metrics package  for spark-engine will be ignored
   
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/kyuubi/metrics/
   ```
   
   This patch changes the rule in `.gitignore` to only exclude metrics 
directory created by JSON reporter in root directory of REPO which is usually 
working directory of debug process.
   
   Close https://github.com/apache/kyuubi/issues/4546
   
   ## Simple test 
   
   
![image](https://github.com/apache/kyuubi/assets/21239012/2c5e879f-a406-43ca-8361-5d3df6d1bab3)
   
   
   ## How was this patch tested?
   - [ ] Add some test cases that check the changes thoroughly including 
negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run 
test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests)
 locally before make a pull request


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to