cxzl25 commented on code in PR #6112:
URL: https://github.com/apache/kyuubi/pull/6112#discussion_r1506980370
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/kyuubi/SQLOperationListener.scala:
##########
@@ -61,6 +63,9 @@ class SQLOperationListener(
None
}
+ val operationRunTime = new AtomicLong(0)
+ val operationCpuTime = new AtomicLong(0)
Review Comment:
External access variables should be allowed to read only.
```suggestion
private val operationRunTime = new AtomicLong(0)
private val operationCpuTime = new AtomicLong(0)
def getOperationRunTime: Long = operationRunTime.get()
def getOperationCpuTime: Long = operationCpuTime.get()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
