wForget commented on code in PR #6112:
URL: https://github.com/apache/kyuubi/pull/6112#discussion_r1510610593
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/events/SessionEvent.scala:
##########
@@ -47,7 +47,9 @@ case class SessionEvent(
conf: Map[String, String],
startTime: Long,
var endTime: Long = -1L,
- var totalOperations: Int = 0) extends KyuubiEvent with SparkListenerEvent {
+ var totalOperations: Int = 0,
+ var sessionRunTime: Long = 0,
Review Comment:
@XorSum Can you add comments for the newly added parameters?
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/events/SparkOperationEvent.scala:
##########
@@ -59,7 +59,9 @@ case class SparkOperationEvent(
exception: Option[Throwable],
sessionId: String,
sessionUser: String,
- executionId: Option[Long]) extends KyuubiEvent with SparkListenerEvent {
+ executionId: Option[Long],
+ operationRunTime: Option[Long],
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
