wForget commented on code in PR #5852:
URL: https://github.com/apache/kyuubi/pull/5852#discussion_r1525861667
##########
extensions/spark/kyuubi-extension-spark-3-5/src/main/scala/org/apache/kyuubi/sql/watchdog/MaxScanStrategy.scala:
##########
@@ -232,6 +234,53 @@ case class MaxScanStrategy(session: SparkSession)
logicalRelation.catalogTable)
}
}
+ case ScanOperation(
+ _,
+ _,
+ _,
+ relation @ DataSourceV2ScanRelation(_, scan:
SupportsReportPartitioning, _, _, _)) =>
+ val table = relation.relation.table
+ if (table.partitioning().nonEmpty) {
+ val partitionColumnNames = table.partitioning().map(_.describe())
+ val stats = relation.computeStats()
+ lazy val scanFileSize = stats.sizeInBytes
+ lazy val scanPartitions = scan
+ .outputPartitioning()
+ .numPartitions()
+ if (maxFileSizeOpt.exists(_ < scanFileSize)) {
Review Comment:
check partitions first, getting the number of partitions may be less
expensive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
