Yikf commented on code in PR #6235:
URL: https://github.com/apache/kyuubi/pull/6235#discussion_r1547390077
##########
externals/kyuubi-spark-sql-engine/src/main/scala-2.12/org/apache/kyuubi/engine/spark/repl/KyuubiSparkILoop.scala:
##########
@@ -28,47 +29,35 @@ import org.apache.spark.repl.SparkILoop
import org.apache.spark.sql.{DataFrame, SparkSession}
import org.apache.spark.util.MutableURLClassLoader
-import org.apache.kyuubi.Utils
+import org.apache.kyuubi.{Logging, Utils}
private[spark] case class KyuubiSparkILoop private (
spark: SparkSession,
output: ByteArrayOutputStream)
- extends SparkILoop(None, new PrintWriter(output)) {
+ extends SparkILoop(None, new PrintWriter(output)) with Logging {
import KyuubiSparkILoop._
val result = new DataFrameHolder(spark)
private def initialize(): Unit = withLockRequired {
+ val currentClassLoader = Thread.currentThread().getContextClassLoader
+ val interpreterClasspath =
getAllJars(currentClassLoader).mkString(File.pathSeparator)
+ info(s"Adding jars to Scala interpreter's class path:
$interpreterClasspath")
settings = new Settings
val interpArguments = List(
"-Yrepl-class-based",
"-Yrepl-outdir",
- s"${spark.sparkContext.getConf.get("spark.repl.class.outputDir")}")
+ s"${spark.sparkContext.getConf.get("spark.repl.class.outputDir")}",
+ "-classpath",
+ interpreterClasspath)
settings.processArguments(interpArguments, processAll = true)
settings.usejavacp.value = true
- val currentClassLoader = Thread.currentThread().getContextClassLoader
settings.embeddedDefaults(currentClassLoader)
this.createInterpreter()
this.initializeSynchronous()
try {
this.compilerClasspath
this.ensureClassLoader()
- var classLoader: ClassLoader =
Thread.currentThread().getContextClassLoader
- while (classLoader != null) {
- classLoader match {
- case loader: MutableURLClassLoader =>
- val allJars = loader.getURLs.filter { u =>
- val file = new File(u.getPath)
- u.getProtocol == "file" && file.isFile &&
- file.getName.contains("scala-lang_scala-reflect")
- }
- this.addUrlsToClassPath(allJars: _*)
Review Comment:
Just a question, Is there a fundamental difference between `-classpath` and
`addUrlsToClassPath `? Why can `-classpath` solve this problem in this way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
