sudohainguyen commented on code in PR #6301:
URL: https://github.com/apache/kyuubi/pull/6301#discussion_r1562041283
##########
charts/kyuubi/templates/kyuubi-servicemonitor.yaml:
##########
@@ -28,7 +28,7 @@ metadata:
spec:
selector:
matchLabels:
- app: {{ .Release.Name }}
+ {{- include "kyuubi.selectorLabels" $ | nindent 6 }}
Review Comment:
yeah no differences in this case I believe
generally `$` is about to pass additional data to the template from global
context in case the included template uses it, other wise `.` only passes local
context defined within that yaml file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
