yanghua commented on code in PR #6284:
URL: https://github.com/apache/kyuubi/pull/6284#discussion_r1565547785


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/BatchesResource.scala:
##########
@@ -332,6 +339,12 @@ private[v1] class BatchesResource extends 
ApiRequestContext with Logging {
                 Some(userName),
                 // prevent that the batch be marked as terminated if 
application state is NOT_FOUND
                 Some(metadata.engineOpenTime).filter(_ > 
0).orElse(Some(System.currentTimeMillis)))
+              // if the batch app is terminated, update the metadata in db.
+              if (BatchJobSubmission.applicationTerminated(batchAppStatus)) {
+                sessionManager.updateMetadata(Metadata(
+                  identifier = batchId,
+                  engineState = batchAppStatus.get.state.toString))

Review Comment:
   +1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to