wForget commented on code in PR #6386:
URL: https://github.com/apache/kyuubi/pull/6386#discussion_r1597399525


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/YarnApplicationOperation.scala:
##########
@@ -95,74 +95,139 @@ class YarnApplicationOperation extends 
ApplicationOperation with Logging {
     }
   }
 
+  private def withNewYarnClient[T](
+      proxyUser: Option[String],
+      sessionConf: Option[KyuubiConf])(action: YarnClient => T): T = {
+    (sessionConf) match {
+      case Some(sessionConf) =>
+        (proxyUser) match {
+          case Some(user) =>
+            Utils.doAs(user) { () =>
+              var yarnClient: YarnClient = null
+              try {
+                val yarnConf = 
KyuubiHadoopUtils.newYarnConfiguration(sessionConf)

Review Comment:
   Does this use `kyuubi.engineEnv.HADOOP_CONF_DIR/YARN_CONF_DIR` in 
sessionConf to initialize `yarnConf`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to