pan3793 commented on code in PR #6473:
URL: https://github.com/apache/kyuubi/pull/6473#discussion_r1642658803
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/ExecuteStatement.scala:
##########
@@ -104,6 +104,7 @@ class ExecuteStatement(
onError(cancel = true)
} finally {
shutdownTimeoutMonitor()
+ if (!spark.sparkContext.isStopped)
spark.sparkContext.cancelJobGroup(statementId)
Review Comment:
so it would be better to
- skip the cancellation here for incremental collect queries. or
- add an internal flag to control whether to skip the cancellation here for
incremental collect queries, skipping by default for safety.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
