dnskr commented on code in PR #6530:
URL: https://github.com/apache/kyuubi/pull/6530#discussion_r1680616450
##########
bin/kyuubi:
##########
@@ -102,7 +102,7 @@ if [[ -n ${YARN_CONF_DIR} ]]; then
KYUUBI_CLASSPATH="${KYUUBI_CLASSPATH}:${YARN_CONF_DIR}"
fi
-cmd="${RUNNER} ${KYUUBI_JAVA_OPTS} -cp ${KYUUBI_CLASSPATH} $CLASS"
+cmd="${RUNNER} ${KYUUBI_JAVA_OPTS} -cp ${KYUUBI_CLASSPATH} $CLASS ${@:2}"
Review Comment:
@pan3793 I added commit to address your initial suggestion. Please, have a
look if it looks good.
---
> > Why do we need to support running Kyuubi as a daemon with `bin/kyuubi`
without `start` command?
>
> this is a behavior from the very beginning, let's keep it to avoid
breaking the user experience
>
Right. It is make sense to leave it as is, at least before Kyuubi 2.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
