pan3793 commented on code in PR #6540:
URL: https://github.com/apache/kyuubi/pull/6540#discussion_r1680945143
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -317,7 +317,8 @@ class KyuubiSessionImpl(
}
def checkEngineConnectionAlive(): Boolean = {
- if (Option(client).exists(_.engineConnectionClosed)) return false
+ if (client == null) return true // client has not been initialized
Review Comment:
> when client is null, `Option(client).exists(_.engineConnectionClosed)`
should be false?
correct, then it goes to the next line, and NPE occurs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
