pan3793 commented on code in PR #6008:
URL: https://github.com/apache/kyuubi/pull/6008#discussion_r1710980527
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/AdminResource.scala:
##########
@@ -286,24 +288,38 @@ private[v1] class AdminResource extends ApiRequestContext
with Logging {
}
val engine = normalizeEngineInfo(userName, engineType, shareLevel,
subdomain, "default")
val engineSpace = calculateEngineSpace(engine)
+ val responseMsgBuilder = new StringBuilder()
withDiscoveryClient(fe.getConf) { discoveryClient =>
- val engineNodes = discoveryClient.getChildren(engineSpace)
- engineNodes.foreach { node =>
- val nodePath = s"$engineSpace/$node"
+ val engineNodes = discoveryClient.getServiceNodesInfo(engineSpace,
silent = true)
+ engineNodes.foreach { engineNode =>
+ val nodePath = s"$engineSpace/${engineNode.nodeName}"
+ val engineRefId = engineNode.engineRefId.orNull
info(s"Deleting engine node:$nodePath")
Review Comment:
except for CONNECTION level engine, we cannot guarantee that there are no
other engines access the same `engineSpace`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
