dupen01 commented on code in PR #6603:
URL: https://github.com/apache/kyuubi/pull/6603#discussion_r1713294187
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JDBCMetadataStore.scala:
##########
@@ -80,7 +80,8 @@ class JDBCMetadataStore(conf: KyuubiConf) extends
MetadataStore with Logging {
hikariConfig.setPoolName("jdbc-metadata-store-pool")
@VisibleForTesting
- implicit private[kyuubi] val hikariDataSource = new
HikariDataSource(hikariConfig)
+ implicit private[kyuubi] val hikariDataSource: HikariDataSource =
+ new HikariDataSource(hikariConfig)
Review Comment:
With Scala 2.13.11 or above(2.13.9, 2.13.10 not tested), if we use previous
code `implicit private[kyuubi] val hikariDataSource = new
HikariDataSource(hikariConfig)`, an error will occur during the compilation
phase:
```
kyuubi/kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JDBCMetadataStore.scala:83:
Implicit definition should have explicit type (inferred
com.zaxxer.hikari.HikariDataSource) [quickfixable]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
