turboFei commented on code in PR #6608:
URL: https://github.com/apache/kyuubi/pull/6608#discussion_r1716077274
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/service/authentication/EngineSecureAuthenticationProviderImpl.scala:
##########
@@ -17,8 +17,12 @@
package org.apache.kyuubi.service.authentication
-class EngineSecureAuthenticationProviderImpl extends
PasswdAuthenticationProvider {
+class EngineSecureAuthenticationProviderImpl extends
PasswdAuthenticationProvider
+ with TokenAuthenticationProvider {
override def authenticate(user: String, password: String): Unit = {
InternalSecurityAccessor.get().authToken(password)
}
+ override def authenticate(token: String): Unit = {
+ InternalSecurityAccessor.get().authToken(token)
+ }
Review Comment:
not needed for `EngineSecureAuthenticationProviderImpl`.
EngineSecureAuthenticationProviderImpl only for
`PasswdAuthenticationProvider`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
