paul8263 commented on code in PR #6616:
URL: https://github.com/apache/kyuubi/pull/6616#discussion_r1716502032
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/ui/JettyServer.scala:
##########
@@ -78,7 +78,8 @@ object JettyServer {
host: String,
port: Int,
poolSize: Int,
- stopTimeout: Long): JettyServer = {
+ stopTimeout: Long,
+ shouldSendJettyVersion: Boolean = true): JettyServer = {
Review Comment:
Hi @pan3793 ，
Thanks for your suggestion. As long as there are only 2 places calling the
constructor of JettyServer. We could remove the default value for the new
introduced sendServerVersion parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
