tigrulya-exe commented on issue #5383: URL: https://github.com/apache/kyuubi/issues/5383#issuecomment-2291264340
@pan3793 @yaooqinn Hi! Just to clarify - do I understand correctly, that for the first iteration, we need to somehow allow gRPC-based engines to coexist with Thrift ones (all current engines) in order to add the `SPARK_CONNECT` engine? That also means, that we will need to rewrite a significant part of the internal communication logic, including`KyuubiSession`, `SessionManager`, etc. or decouple it from Thrift. Or it is expected to start directly from rewriting the current internal RPC mechanism from Thrift (HS2) to gRPC and changing the internal API (`kyuubi frontend server <--> engine`), so that it will include logical methods from both the old API and the Spark Connect API? > currently, we use Thrift(more specifically, the HiveServer2 Thrift protocol) as the internal RPC protocol, but for connect, obviously gRPC should be used -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
