bowenliang123 commented on code in PR #6629:
URL: https://github.com/apache/kyuubi/pull/6629#discussion_r1722573214
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiBatchSession.scala:
##########
@@ -82,8 +82,8 @@ class KyuubiBatchSession(
override val normalizedConf: Map[String, String] =
sessionConf.getBatchConf(batchType) ++
sessionManager.validateBatchConf(conf)
- private[kyuubi] def resourceUploadFolderPath: Path =
- BatchesResource.batchResourceUploadFolderPath(batchJobSubmissionOp.batchId)
+ private[kyuubi] lazy val resourceUploadFolderPath: Path =
Review Comment:
```suggestion
private[kyuubi] def resourceUploadFolderPath: Path =
```
Minor optional suggestion: function instead of holding the variable, as it's
able to be recalculated.
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/BatchesResource.scala:
##########
@@ -642,6 +642,8 @@ object BatchesResource {
Option(batchState).exists(bt =>
VALID_BATCH_STATES.contains(bt.toUpperCase(Locale.ROOT)))
}
- def batchResourceUploadFolderPath(batchId: String): JPath =
- KyuubiApplicationManager.uploadWorkDir.resolve(s"batch-$batchId")
Review Comment:
I have removed the prefix `batch-` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
