paul8263 commented on code in PR #6685:
URL: https://github.com/apache/kyuubi/pull/6685#discussion_r1755917784
##########
kyuubi-metrics/src/main/scala/org/apache/kyuubi/metrics/PrometheusReporterService.scala:
##########
@@ -79,11 +90,13 @@ class PrometheusReporterService(registry: MetricRegistry)
if (httpServer != null) {
try {
httpServer.stop()
+ connector.stop()
Review Comment:
Hi @bowenliang123 ,
Thanks for the review.
I refered to the codes in JettyServer, in which the stop method closes the
server first and then the server conenctor. I think it should work as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
