vinayakmalik95 opened a new issue, #6706:
URL: https://github.com/apache/kyuubi/issues/6706

   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I have searched in the 
[issues](https://github.com/apache/kyuubi/issues?q=is%3Aissue) and found no 
similar issues.
   
   
   ### Describe the bug
   
   Lineage is returned as empty since we dont return the parentColumnLineage 
   
   ### but an empty AttributeSet()
   case p if p.children.isEmpty => ListMap[Attribute, AttributeSet]()
   ![Screenshot 2024-09-19 at 6 18 23 
PM](https://github.com/user-attachments/assets/4156b47d-9953-4729-8a03-7c3a1ffabe4b)
   
   ### where as it should be
   case p if p.children.isEmpty => parentColumnsLineage
   ![Screenshot 2024-09-19 at 6 17 02 
PM](https://github.com/user-attachments/assets/0aaf4a1c-6823-46a7-bbb4-8928cfffa27a)
   
   
   
   ### Affects Version(s)
   
   https://github.com/apache/kyuubi/releases/tag/v1.9.2
   
   ### Kyuubi Server Log Output
   
   ```logtalk
   No error in server logs, you can test it simply by running test cases like
   
     test("columns lineage extract - AppendData/OverwriteByExpression") {
       val ddls =
         """
           |create table v2_catalog.db.tb0(col1 int, col2 string) partitioned 
by(col2)
           |""".stripMargin
       ddls.split("\n").filter(_.nonEmpty).foreach(spark.sql(_).collect())
       withTable("v2_catalog.db.tb0") { _ =>
         val ret0 =
           extractLineage(
             s"insert into table v2_catalog.db.tb0 " +
               s"select key as col1, value as col2 from test_db0.test_table0")
         assert(ret0 == Lineage(
           List(s"$DEFAULT_CATALOG.test_db0.test_table0"),
           List("v2_catalog.db.tb0"),
           List(
             ("v2_catalog.db.tb0.col1", 
Set(s"$DEFAULT_CATALOG.test_db0.test_table0.key")),
             ("v2_catalog.db.tb0.col2", 
Set(s"$DEFAULT_CATALOG.test_db0.test_table0.value")))))
   
         val ret1 =
           extractLineage(
             s"insert overwrite table v2_catalog.db.tb0 partition(col2) " +
               s"select key as col1, value as col2 from test_db0.test_table0")
         assert(ret1 == Lineage(
           List(s"$DEFAULT_CATALOG.test_db0.test_table0"),
           List("v2_catalog.db.tb0"),
           List(
             ("v2_catalog.db.tb0.col1", 
Set(s"$DEFAULT_CATALOG.test_db0.test_table0.key")),
             ("v2_catalog.db.tb0.col2", 
Set(s"$DEFAULT_CATALOG.test_db0.test_table0.value")))))
   
         val ret2 =
           extractLineage(
             s"insert overwrite table v2_catalog.db.tb0 partition(col2 = 'bb') 
" +
               s"select key as col1 from test_db0.test_table0")
         assert(ret2 == Lineage(
           List(s"$DEFAULT_CATALOG.test_db0.test_table0"),
           List("v2_catalog.db.tb0"),
           List(
             ("v2_catalog.db.tb0.col1", 
Set(s"$DEFAULT_CATALOG.test_db0.test_table0.key")),
             ("v2_catalog.db.tb0.col2", Set()))))
       }
     }
   ```
   
   
   ### Kyuubi Engine Log Output
   
   ```logtalk
   Empty Lineage returned : 
   
   inputTables(List())
   outputTables(List())
   columnLineage(List())
   
   ### Whereas it should return lineage like
   Lineage(
           List(s"$DEFAULT_CATALOG.test_db0.test_table0"),
           List("v2_catalog.db.tb0"),
           List(
             ("v2_catalog.db.tb0.col1", 
Set(s"$DEFAULT_CATALOG.test_db0.test_table0.key")),
             ("v2_catalog.db.tb0.col2", 
Set(s"$DEFAULT_CATALOG.test_db0.test_table0.value")))))
   
   
   this test fails 
   
   ### Test name :   test("columns lineage extract - 
AppendData/OverwriteByExpression")
   ```
   
   
   ### Kyuubi Server Configurations
   
   _No response_
   
   ### Kyuubi Engine Configurations
   
   _No response_
   
   ### Additional context
   
   By uddating the logic when
   
   ### case p if p.children.isEmpty
   we should return the parentColumnLineage instead of empty ListMap[Attribute, 
AttributeSet]()
   
   
   ### Are you willing to submit PR?
   
   - [X] Yes. I would be willing to submit a PR with guidance from the Kyuubi 
community to fix.
   - [ ] No. I cannot submit a PR at this time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to