pan3793 opened a new pull request, #6708: URL: https://github.com/apache/kyuubi/pull/6708
# :mag: Description ## Issue References ๐ <!-- Append the issue number after #. If there is no issue for you to link create one or --> <!-- If there are no issues to link, please provide details here. --> The server module does not consume the `spark-sql-engine` classes, but it supposes that `spark-sql-engine`'s jar existed on the target folder, so here we declare it as a dependency to make sure that Maven always processes `spark-sql-engine` module before the server module. IntelliJ IDEA 2024.1 fixed the IDEA-93855, thus the relocated classes inside the `spark-sql-engine`'s shaded jar are visible in the server module in IDEA, for example, `org.apache.kyuubi.shaded.spark.connect.proto.ExecutePlanRequest`, which silently breaks the IDEA code analysis and jumping capabilities. ## Describe Your Solution ๐ง Changing the dependency type from `jar`(default value) to `pom` seems to be a workaround. ## Types of changes :bookmark: <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan ๐งช <img width="593" alt="image" src="https://github.com/user-attachments/assets/cc53709a-5f9d-4452-a24f-0c84e2342191";> #### Behavior Without This Pull Request :coffin: <img width="1511" alt="image" src="https://github.com/user-attachments/assets/1c547c6d-a603-4c9d-92b4-8e2059b35fac";> #### Behavior With This Pull Request :tada: <img width="1509" alt="image" src="https://github.com/user-attachments/assets/55f9e6e5-b9ea-4959-9142-ab7db21ab9b1";> --- # Checklist ๐ <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
