Madhukar525722 commented on code in PR #6374:
URL: https://github.com/apache/kyuubi/pull/6374#discussion_r1817930304
##########
bin/kyuubi:
##########
@@ -106,7 +106,20 @@ cmd="${RUNNER} ${KYUUBI_JAVA_OPTS} -cp ${KYUUBI_CLASSPATH}
$CLASS"
pid="${KYUUBI_PID_DIR}/kyuubi-$USER-$CLASS.pid"
+function get_pid(){
+ if [[ ! -w ${KYUUBI_PID_DIR} ]]; then
+ echo "${USER} does not have 'w' permission to ${KYUUBI_PID_DIR}"
+ exit 1
+ fi
+
+ run_pid="$(ps -ef | grep kyuubi | grep java | grep -v grep | awk '{print
$2}')"
Review Comment:
Hi @zhouyifan279 , I have updated the implementation, now I am making the
selection on
1. org.apache.kyuubi.server.KyuubiServer - Ensures its an server process
2. $KYUUBI_CONF_DIR - Kyuubi conf dir path, displayed in the complete
process details. This identifier is choosen to differentiate between the
instances, because different instances cant run with same conf, as it will
cause port already in use error.
Please review the changes.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
